Re: [PATCH] lsblk: improve error reporting for invalid device paths

Benno Schulenberg <[email protected]> Sat, 14 Feb 2026 16:24:42 +0100

Newsgroups	org.kernel.vger.util-linux
Message-ID	<[email protected]>

Op 12-02-2026 om 12:24 schreef sina-abroshan:
> -		struct stat st;
> +    	struct stat st;
>   
> -		DBG(DEV, ul_debug("%s: reading alone device", devname));
> +    	DBG(DEV, ul_debug("%s: reading alone device", devname));

Why these whitespace changes?  There should be tabs there, not spaces.

> -		if (stat(devname, &st) || !S_ISBLK(st.st_mode)) {
> +		if (stat(devname, &st) != 0) {
> +			warn(_("%s"), devname);
Gettextizing a message that contains nothing translatable is pointless.
In other words: drop the _() call.


Benno

OpenPGP_signature.asc (application/pgp-signature, 840 B)