Re: [PATCH 1/3] nsenter: (usage) correct the formatting of eight option arguments

On Sun, Mar 8, 2026 at 7:20=E2=80=AFPM Benno Schulenberg <bensberg@telfort.=
nl> wrote:
>
> Angle brackets should wrap each placeholder separately: <file> and
> <nsid>.  Angle brackets should not enclose metacharacters (|) nor
> literal ones (=3D and :).
>
> (The mistaken formatting was introduced by commit f2a5997869.)
>
> CC: Xiao Liang <[email protected]>
> Signed-off-by: Benno Schulenberg <[email protected]>
> ---
>  sys-utils/nsenter.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sys-utils/nsenter.c b/sys-utils/nsenter.c
> index f93e75af2..98da75511 100644
> --- a/sys-utils/nsenter.c
> +++ b/sys-utils/nsenter.c
> @@ -97,16 +97,16 @@ static void __attribute__((__noreturn__)) usage(void)
>         fputs(USAGE_OPTIONS, out);
>         fputs(_(" -a, --all                    enter all namespaces\n"), =
out);
>         fputs(_(" -t, --target <PID>           target process to get name=
spaces from\n"), out);
> -       fputs(_(" -m, --mount[=3D<file|:nsid>]   enter mount namespace\n"=
), out);
> -       fputs(_(" -u, --uts[=3D<file|:nsid>]     enter UTS namespace (hos=
tname etc)\n"), out);
> -       fputs(_(" -i, --ipc[=3D<file|:nsid>]     enter System V IPC names=
pace\n"), out);
> -       fputs(_(" -n, --net[=3D<file|:nsid>]     enter network namespace\=
n"), out);
> +       fputs(_(" -m, --mount[=3D<file>|=3D:<nsid>]  enter mount namespac=
e\n"), out);
> +       fputs(_(" -u, --uts[=3D<file>|=3D:<nsid>]  enter UTS namespace (h=
ostname etc)\n"), out);
> +       fputs(_(" -i, --ipc[=3D<file>|=3D:<nsid>]  enter System V IPC nam=
espace\n"), out);
> +       fputs(_(" -n, --net[=3D<file>|=3D:<nsid>]  enter network namespac=
e\n"), out);
>         fputs(_(" -N, --net-socket <fd>        enter socket's network nam=
espace (use with --target)\n"), out);
> -       fputs(_(" -p, --pid[=3D<file|:nsid>]     enter pid namespace\n"),=
 out);
> -       fputs(_(" -C, --cgroup[=3D<file|:nsid>]  enter cgroup namespace\n=
"), out);
> -       fputs(_(" -U, --user[=3D<file|:nsid>]    enter user namespace\n")=
, out);
> +       fputs(_(" -p, --pid[=3D<file>|=3D:<nsid>]  enter pid namespace\n"=
), out);
> +       fputs(_(" -C, --cgroup[=3D<file>|=3D:<nsid>]  enter cgroup namesp=
ace\n"), out);
> +       fputs(_(" -U, --user[=3D<file>|=3D:<nsid>] enter user namespace\n=
"), out);
>         fputs(_("     --user-parent            enter parent user namespac=
e\n"), out);
> -       fputs(_(" -T, --time[=3D<file|:nsid>]    enter time namespace\n")=
, out);
> +       fputs(_(" -T, --time[=3D<file>|=3D:<nsid>] enter time namespace\n=
"), out);
>         fputs(_(" -S, --setuid[=3D<uid>]         set uid in entered names=
pace\n"), out);
>         fputs(_(" -G, --setgid[=3D<gid>]         set gid in entered names=
pace\n"), out);
>         fputs(_("     --preserve-credentials   do not touch uids or gids\=
n"), out);
> --
> 2.53.0
>

Looks good. Thanks for the correction.