Re: [PATCH 2/2] lsmem: (man) correct the markup of column names, and improve some grammar

On Wed, Mar 11, 2026 at 01:27:03PM +0100, Karel Zak wrote:
> On Mon, Mar 09, 2026 at 01:36:32PM +0100, Sumanth Korikkar wrote:
> > How about the following?
> > Example STATE, CONFIGURED, MEMMAP-ON-MEMORY states:
> > STATE   | CONFIGURED | MEMMAP-ON-MEMORY | Description
> > online  | yes        | yes              | Memory block is configured with memmap-on-memory enabled and online.
> > online  | yes        | no               | Memory block is configured with memmap-on-memory disabled and online.
> > offline | yes        | yes              | Memory block is configured but currently offline.
> > offline | no         | yes              | Memory block is deconfigured and was previously configured with memmap-on-memory.
> > offline | no         | no               | Memory block is deconfigured and was not previously configured with memmap-on-memory.

Hi Karel,

> I personally prefer structured information like lists or tables and
> dislike large text blocks ;-) 

I chose a table because I felt it would show the state combinations more
clearly. But I understand it does make the text heavier.

> However, in this case, I'm not sure if the description adds anything,
> as it repeats what is obvious from STATE, CONFIGURED, MEMMAP-ON-MEMORY
> columns.

Thanks for the feedback. In that case, we can drop the
table and keep the sentence which was proposed earlier.

> What I find relevant is "previously configured." Maybe add a sentence
> stating that CONFIGURED and MEMMAP-ON-MEMORY for _offline_ blocks show
> the previous setup.

For offline blocks, only the MEMMAP‑ON‑MEMORY value reflects the
previous setup or the initial default.  If this value isn’t changed
during the next configuration, it will simply be carried forward and
used again.

An offline but configured block is possible.
chmem -c -b <blockno> -m 1

Thanks & Regards,
Sumanth