Re: [PATCH v3 1/2] kunit: tool: Parse and print the reason tests are skipped
Thomas Weißschuh <[email protected]> Fri, 5 Jun 2026 08:58:42 +0200
| Newsgroups | org.kernel.vger.workflows,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <20260605085615-8c7c7024-3af8-4016-8d9f-7c7af30734e4@linutronix.de> |
On Thu, Jun 04, 2026 at 08:32:04PM +0800, David Gow wrote: > When a KUnit test (or other KTAP test) is skipped, a "skip reason" can be > provided. kunit.py has never done anything with this, ignoring anything > included in the KTAP output after the 'SKIP' directive. > > Since we have it, and it's used, print it in a nice friendly yellow in > parentheses after a skipped test's name. > > (And, by parsing it, it can be included in the JUnit results as well.) Some tests would be nice. > Signed-off-by: David Gow <[email protected]> > --- > > There are a few bits of KTAP that kunit.py has never actually parsed, and > this is one of them. It's also nice to have a good way of quickly seeing > why a test has been skipped, given most tests do provide good reason > strings. > > Happy to hear comments about the style: yellow in parentheses looks pretty > good here, but could be a bit confusing if KUnit do Something is missing here? For [SKIPPED] the brackets are colored, too. > This is the first version of this patch, as it's a new dependency of v3 of > patch 2, the JUnit support, which also includes the skip reason. > > -- > tools/testing/kunit/kunit_parser.py | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) (...)