Re: [PATCH] checkpatch: Validate committer sign-off

Bartosz Golaszewski <[email protected]> Tue, 28 Jul 2026 07:28:37 -0700

Newsgroups	org.kernel.vger.workflows,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel
Message-ID	<CAMRc=McFJaotv-Y=_hzHR5-1UL6d3Ggka0Nm3dSOkvn1UUijaw@mail.gmail.com>

On Fri, 24 Jul 2026 20:56:00 +0200, Bjorn Andersson
<[email protected]> said:
> checkpatch validates the Signed-off-by trailers against the patch's
> author, but misses the opportunity to also validate the committer when
> run with --git. Maintainers therefor need third-party scripts for the
> final Signed-off-by check.
>
> git format-patch provides the author and patch content, but not the
> committer. Extend the existing git log extraction to record the
> committer identity.
>
> Extract the author sign-off comparison logic into a shared helper, and
> use it to apply the same heuristics to the final Signed-off-by trailer
> and committer.
>
> Emit COMMITTER_SIGN_OFF_MISMATCH when the final trailer does not match
> the committer.
>
> Assisted-by: OpenCode:GPT-5.5
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---

I too would like to see this applied. The alternative is to get emails from
linux-next maintainers after a bad commit is already published, which requires
rebasing of maintainers' trees.

Acked-by: Bartosz Golaszewski <[email protected]>

Thanks,
Bartosz