Re: [PATCH] checkpatch.pl: adapt to new Assisted-by: format

Jeff Layton <[email protected]>
Newsgroups org.kernel.vger.workflows,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Tue, 2026-08-04 at 09:23 -0700, Joe Perches wrote:
> On Tue, 2026-08-04 at 12:13 -0400, Jeff Layton wrote:
> > There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> > to just check that it has a value rather than testing for a specific
> > format.
> > 
> > Assisted-by: LLM
> 
> Did an LLM really help produce this?  Why?
> 

Why not? It was simple to have it do it, and my perl skills are a bit
rusty. I don't love typing, fwiw...

> > Signed-off-by: Jeff Layton <[[email protected]](mailto:[email protected])>
> > ---
> > This is a companion patch to the one to change the format in
> > Documentation/. See:
> > 
> >     [https://lore.kernel.org/workflows/[email protected]/](https://lore.kernel.org/workflows/[email protected]/)
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3124,11 +3124,12 @@ sub process {
> >  				}
> >  			}
> >  
> > -			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> > +			# Assisted-by uses a free-form value (e.g. "LLM"), not an
> > +			# email address, so skip the email format checks below.
> >  			if ($sign_off =~ /^Assisted-by:/i) {And
> > -				if ($email !~ /^\S+:\S+/) {
> > +				if ($email =~ /^\s*$/) {
> >  					WARN("BAD_SIGN_OFF",
> > -					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> > +					     "Assisted-by requires a value\n" . $herecurr);
> >  				}
> >  				next;
> >  			}
> > 
> []
> > Best regards,
> 
> Sure, whatever.
> 
> cheers

-- 
Jeff Layton <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.