Re: [PATCH v6 0/6] selftests/mm: separate GUP microbenchmarking from functional testing
Mike Rapoport <[email protected]> Mon, 03 Aug 2026 12:00:01 +0300
| Newsgroups | org.kvack.linux-mm,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <178574760161.1561566.2419225666600419775.b4-review@b4> |
> gup_test.c currently serves two separate purposes: benchmarking > (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK and PIN_LONGTERM_BENCHMARK) and > functional testing (GUP_BASIC_TEST, PIN_BASIC_TEST and > DUMP_USER_PAGES_TEST). Keeping both in one program makes the functional > tests harder to run and report individually, while run_vmtests.sh has to > invoke the program repeatedly with different options. > > Separate these roles into tools/mm/gup_bench for benchmarking and > tools/testing/selftests/mm/gup for functional testing. Move the shared > file and hugepage helpers to tools/lib/mm/ so both programs can use them > without duplicating the implementation. This sets seems to regress hugetlb tests: https://github.com/linux-mm/linux-mm/actions/runs/30553882784/job/90909219578 -- Sincerely yours, Mike.