Re: [PATCH V3] mm: Standardize printing for pgtable entries

"David Hildenbrand (Arm)" <[email protected]>
Newsgroups org.kvack.linux-mm,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 7/9/26 06:43, Anshuman Khandual wrote:
> From: "David Hildenbrand (Arm)" <[email protected]>
> 
> Bad page map reporting currently stores page table entry values in an
> unsigned long long and prints them with fixed 64-bit-oriented format
> strings. This is inconsistent across call sites and does not work well for
> architectures where page table entry values are not naturally represented
> as 64-bit values, such as 32-bit or 128-bit entries.
> 
> Introduce a common helper to convert raw page table entry values into a
> fixed-width hexadecimal string based on the actual entry size. Use it for
> bad page map reporting and for dumping the page table walk in
> __print_bad_page_map_pgtable().
> 
> Pass page table entry values to the reporting path as raw bytes together
> with their size, instead of forcing them through an unsigned long long.
> It keeps the printed output consistent and avoids truncation or misleading
> formatting for non-64-bit page table entries.
> 
> Cc: Andrew Morton <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: David Hildenbrand (Arm) <[email protected]>
> Co-developed-by: Anshuman Khandual <[email protected]>
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---

From the discussion I conclude that this patch is good to go now. I wrote it,
Anshuman cleaned it up.

LGTM

(adding my own ACK/RB is weird ;) )

-- 
Cheers,

David
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.