Re: [PATCH v3 3/5] selftests/mm: skip khugepaged swap tests without swap

On 7/27/26 11:52, Muhammad Usama Anjum wrote:
> collapse_swapin_single_pte and collapse_max_ptes_swap require
> MADV_PAGEOUT to replace anonymous pages with swap entries. On swapless
> systems there is no backing store with which to create those entries,
> so check_swap() reports missing setup rather than broken khugepaged
> behavior.
> 
> Swapless configurations are common on Android and other constrained
> test devices. Failing these cases obscures actionable results from the
> rest of the khugepaged suite.
> 
> Check /proc/swaps before either swap-dependent case and skip when no
> active swap area exists. With swap present, retain the existing
> MADV_PAGEOUT and swap-entry assertions unchanged.
> 
> Print each existing swapout diagnostic before the prerequisite check
> so skip() completes a KTAP diagnostic line instead of emitting an
> unprefixed message.
> 
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---

Didn't I reject a similar patch recently? :)

Ah, yes, actually two similar ones:

https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

And I think what Kiryl proposes is actually the right thing to do:

https://lore.kernel.org/all/[email protected]/

So let's drop this patch.

-- 
Cheers,

David