Re: [PATCH 1/6] mm/mglru: batch update lrugen->nr_pages in inc_min_seq()
"Lian Wang (ProcessMission)" <[email protected]>
| Newsgroups | org.kvack.linux-mm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Lian Wang <[email protected]> Hi Barry, A small nit: > + unsigned long delta = 0; lrugen->nr_pages is a signed long and is documented as being able to transiently go negative while reset_batch_size() is pending. Could delta remain a long as well, so this arithmetic stays signed? In 2/6, where the declarations are combined, this could be: unsigned long protected[MAX_NR_TIERS] = {}; long delta = 0; Thanks, Lian