Re: [PATCH v2] staging: rtl8192e: Fix conflicting types error with net_device.

Greg Kroah-Hartman <[email protected]> Tue, 25 Jun 2024 17:23:19 +0200
Newsgroups org.linuxdriverproject.driverdev-devel,dev.linux.lists.linux-staging,dev.linux.lists.oe-kbuild-all,org.kernel.vger.linux-kernel
Message-ID <2024062553-postbox-gangly-e155@gregkh>
On Tue, Jun 25, 2024 at 04:19:18PM +0100, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
> 
> Fix for commit: 7dff0b27d9c842f88149bf611cbc0b59be1dcd3c:
> [34/59] staging: rtl89192e: Remove unnecessary pre-declaration of struct
> net_device.
> 
> Signed-off-by: Teddy Engel <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> ---
> v2: Add commit id that's being fixed.

You do that with a "Fixes:" tag, not the paragraph you wrote above :)

The documentation should explain how to do it, right?

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel