Re: babeltrace | sink.ctf.fs: add support to create LTTng index

Philippe Proulx via lttng-dev <[email protected]> Mon, 1 Dec 2025 09:38:12 -0500
Newsgroups org.lttng.lists.lttng-dev
Message-ID <CAB4xu_0SBjk5xKXt_Q5gYWDC+iHg=oi08MyGyFhcBvvVmoAfvQ@mail.gmail.com>
On Mon, Dec 1, 2025 at 4:34=E2=80=AFAM MOESSBAUER, Felix via lttng-dev
<[email protected]> wrote:
>
> Hi,
>
> I recently created a babeltrace pull request that adds support to
> create an CTF LTTng index file along the CTF files [1].
>
> It would be great, if someone could review it.

Thank you for your pull requests.

I'll need to look at this in detail, but I'm not against the idea,
especially if it's guarded behind a no-by-default
initialization parameter.

That being said:

=E2=80=A2 We won't review on GitHub: please submit your change to our Gerri=
t
  Code Review system (<https://review.lttng.org/>).

  I know it's a bit more initial work on your side if you're not
  familiar with Gerrit, but the review process will be much easier.

  See <https://review.lttng.org/Documentation/user-upload.html> to learn
  how to upload a change.

  For this reason, I'll close the PRs immediately.

=E2=80=A2 You'll need to add a few tests to validate your feature.

=E2=80=A2 I'll deal with the documentation (manual pages) myself.

=E2=80=A2 Given our current workload before the end of the year, I'm not su=
re
  I'll be able to review this before 2026.

Thank you for your contribution and for your patience with our
review process.

Philippe Proulx
EfficiOS

>
> [1] https://github.com/efficios/babeltrace/pull/123
>
> Best regards,
> Felix Moessbauer
>
> --
> Siemens AG
> Linux Expert Center
> Friedrich-Ludwig-Bauer-Str. 3
> 85748 Garching, Germany
>