[lustre-devel] [PATCH 16/40] lustre: ptlrpc: clarify AT error message
James Simmons <[email protected]> Sun, 9 Apr 2023 08:12:56 -0400
| Newsgroups | org.lustre.lists.lustre-devel |
|---|---|
| Message-ID | <[email protected]> |
From: Aurelien Degremont <[email protected]> Clarify the error message related to passed deadline for AT early replies. It was indicating that the system was CPU bound which is most of the time wrong, as the issue is rather communication failure delaying RPC traffic. This could be confusing to people which will look for CPU resource consumption where the network traffic is more at cause. Also try to use less cryptic keywords which makes only sense to the feature developer, and not to admins. WC-bug-id: https://jira.whamcloud.com/browse/LU-930 Lustre-commit: 9ce04000fba07706c ("LU-930 ptlrpc: clarify AT error message") Signed-off-by: Aurelien Degremont <[email protected]> Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49548 Reviewed-by: Andreas Dilger <[email protected]> Reviewed-by: Yang Sheng <[email protected]> Reviewed-by: Oleg Drokin <[email protected]> Signed-off-by: James Simmons <[email protected]> --- fs/lustre/ptlrpc/service.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/lustre/ptlrpc/service.c b/fs/lustre/ptlrpc/service.c index aaf7529..bf76272 100644 --- a/fs/lustre/ptlrpc/service.c +++ b/fs/lustre/ptlrpc/service.c @@ -1303,12 +1303,11 @@ static void ptlrpc_at_check_timed(struct ptlrpc_service_part *svcpt) * We're already past request deadlines before we even get a * chance to send early replies */ - LCONSOLE_WARN("%s: This server is not able to keep up with request traffic (cpu-bound).\n", - svcpt->scp_service->srv_name); - CWARN("earlyQ=%d reqQ=%d recA=%d, svcEst=%d, delay=%lldms\n", - counter, svcpt->scp_nreqs_incoming, - svcpt->scp_nreqs_active, - at_get(&svcpt->scp_at_estimate), delay_ms); + LCONSOLE_WARN("'%s' is processing requests too slowly, client may timeout. Late by %ds, missed %d early replies (reqs waiting=%d active=%d, at_estimate=%d, delay=%lldms)\n", + svcpt->scp_service->srv_name, -first, counter, + svcpt->scp_nreqs_incoming, + svcpt->scp_nreqs_active, + at_get(&svcpt->scp_at_estimate), delay_ms); } /* -- 1.8.3.1 _______________________________________________ lustre-devel mailing list [email protected] http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org