[lustre-devel] [PATCH 14/25] lustre: obdclass: remove class_parse_nid4()
James Simmons <[email protected]> Thu, 30 Jan 2025 09:11:04 -0500
| Newsgroups | org.lustre.lists.lustre-devel |
|---|---|
| Message-ID | <[email protected]> |
From: Mr NeilBrown <[email protected]> class_parse_nid4() not used any more. WC-bug-id: https://jira.whamcloud.com/browse/LU-10391 Lustre-commit: 89aac3d3b39f68982 ("LU-10391 obdclass: remove class_parse_nid4()") Signed-off-by: Mr NeilBrown <[email protected]> Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50095 Reviewed-by: James Simmons <[email protected]> Reviewed-by: Alex Zhuravlev <[email protected]> Reviewed-by: Oleg Drokin <[email protected]> Signed-off-by: James Simmons <[email protected]> --- fs/lustre/include/obd_class.h | 4 ---- fs/lustre/obdclass/obd_config.c | 31 +------------------------------ 2 files changed, 1 insertion(+), 34 deletions(-) diff --git a/fs/lustre/include/obd_class.h b/fs/lustre/include/obd_class.h index e91335e8cd70..06dfcf9bbd9e 100644 --- a/fs/lustre/include/obd_class.h +++ b/fs/lustre/include/obd_class.h @@ -144,12 +144,8 @@ int class_find_param(char *buf, char *key, char **valp); struct cfg_interop_param *class_find_old_param(const char *param, struct cfg_interop_param *ptr); int class_get_next_param(char **params, char *copy); -int class_parse_nid4(char *buf, lnet_nid_t *nid4, char **endh); -int class_parse_nid4_quiet(char *buf, lnet_nid_t *nid4, char **endh); int class_parse_nid(char *buf, struct lnet_nid *nid, char **endh); int class_parse_nid_quiet(char *buf, struct lnet_nid *nid, char **endh); -int class_parse_net(char *buf, u32 *net, char **endh); -int class_match_net(char *buf, char *key, u32 net); struct obd_device *class_incref(struct obd_device *obd, const char *scope, const void *source); diff --git a/fs/lustre/obdclass/obd_config.c b/fs/lustre/obdclass/obd_config.c index 689e8f54084d..3fe1cb6e5341 100644 --- a/fs/lustre/obdclass/obd_config.c +++ b/fs/lustre/obdclass/obd_config.c @@ -152,19 +152,6 @@ static int class_match_param(char *buf, const char *key, char **valp) return 0; } -static int parse_nid4(char *buf, void *value, int quiet) -{ - lnet_nid_t *nid4 = value; - - *nid4 = libcfs_str2nid(buf); - if (*nid4 != LNET_NID_ANY) - return 0; - - if (!quiet) - LCONSOLE_ERROR_MSG(0x159, "Can't parse NID '%s'\n", buf); - return -EINVAL; -} - static int parse_nid(char *buf, void *value, int quiet) { struct lnet_nid *nid = value; @@ -187,8 +174,7 @@ static int parse_net(char *buf, void *value) } enum { - CLASS_PARSE_NID4 = 1, - CLASS_PARSE_NID, + CLASS_PARSE_NID = 1, CLASS_PARSE_NET, }; @@ -221,9 +207,6 @@ static int class_parse_value(char *buf, int opc, void *value, char **endh, switch (opc) { default: LBUG(); - case CLASS_PARSE_NID4: - rc = parse_nid4(buf, value, quiet); - break; case CLASS_PARSE_NID: rc = parse_nid(buf, value, quiet); break; @@ -239,18 +222,6 @@ static int class_parse_value(char *buf, int opc, void *value, char **endh, return 0; } -int class_parse_nid4(char *buf, lnet_nid_t *nid4, char **endh) -{ - return class_parse_value(buf, CLASS_PARSE_NID4, (void *)nid4, endh, 0); -} -EXPORT_SYMBOL(class_parse_nid4); - -int class_parse_nid4_quiet(char *buf, lnet_nid_t *nid4, char **endh) -{ - return class_parse_value(buf, CLASS_PARSE_NID4, (void *)nid4, endh, 1); -} -EXPORT_SYMBOL(class_parse_nid4_quiet); - int class_parse_nid(char *buf, struct lnet_nid *nid, char **endh) { return class_parse_value(buf, CLASS_PARSE_NID, (void *)nid, endh, 0); -- 2.39.3 _______________________________________________ lustre-devel mailing list [email protected] http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org