[mlmmj] Misleading operations log output: moderation & more

"Robin H. Johnson" <[email protected]> Tue, 13 Feb 2018 21:33:19 +0000

Newsgroups	org.mlmmj.mlmmj
Message-ID	<[email protected]>

Hi,

Recently saw some behavior that was unclear.

The gentoo-dev-announce list is configured as an announce list.
subonlypost, notoccdenymails, nosubonlydenymails, noaccessdenymails,
moderated.

access:
- (lots of deny lines)
- moderate ^From: .*@gentoo.org
- deny

The user was subscribed as [email protected], but sent their mail with
a plus-address suffix in From. The plus-address was not subscribed.

Log output: (wrapped for reading)
mlmmj-process: 
 access - A mail from "[email protected]" with 
 header "From: A User <[email protected]>" was 
 moderated by rule #18 "moderate ^From: .*@gentoo.org"

That was the only log line, and then it seemed to vanish.
What happened is that subonlypost was applied AFTER the access was
processed, and did not log that it decided to drop the mail.
I think that there should be a log message stating it was dropped.

Relatedly, if you try to sub an address that is already on a list, there
should be a log message (and likewise for unsub).

P.S.
'A mail' is also ambiguous on busy lists, since you could have multiple
mails being processed at the same time, need to figure out something to
describe which mail is in logging.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : [email protected]
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

signature.asc (application/pgp-signature, 1.1 KB)