Re: [mlmmj] Re: bug: Index is never incremented

On Sat, Dec 09, 2023 at 08:23:11PM +0100, Baptiste Daroussin wrote:
> > diff --git a/src/incindexfile.c b/src/incindexfile.c
> > index ce85fa2..33fc50e 100644
> > --- a/src/incindexfile.c
> > +++ b/src/incindexfile.c
> > @@ -51,7 +51,7 @@ int incindexfile(int listfd)
> >  		return 0;
> >  	}
> >  
> > -	fp = fdopen(fd, "r");
> > +	fp = fdopen(fd, "r+");
> >  	if (fp == NULL) {
> >  		log_error(LOG_ARGS, "Error fdopening index file");
> >  		close(fd);
> > 
> > 
> > -K
> > 
> > 
> 
> Thank you for the fix, I wonder why the index was not broken for my freebsd
> mailing list using it, it actually is, simply I tested on mailing list without
> archives (bummer) meaning the index does not matter much :(

Just to confirm that everything appears to be working smoothly. I will be
enabling 1.4.1 on more lists this week, including some large-volume ones. If
there are any problems, I will report.

> The testsuite was also too naive.
> 
> 1.4.1 is now out fixing the issue, and the testsuite extended to be less naive
> 
> Sorry about that ridiculous bug :(

Hey, no worries. :) It's one of those bugs that don't manifest themselves
unless you're doing something very specific (like sending digests).

Best regards,
-K