Re: [RFC] 0-length PPDU reporting

Johannes Berg <[email protected]> Fri, 29 Jun 2018 12:49:26 +0200
Newsgroups org.netbsd.radiotap
Message-ID <[email protected]>
On Tue, 2018-06-19 at 15:50 -0700, Guy Harris wrote:
> On Jun 19, 2018, at 2:20 PM, Guy Harris <guy-FrUbXkNCsVf2fBVCVOL8/[email protected]> wrote:
> 
> > On Jun 18, 2018, at 12:20 PM, Johannes Berg <[email protected]> wrote:
> > 
> > > A wireshark patch should be pretty simple, just don't call through to
> > > the 802.11 dissector?
> > 
> > Yes, although if it has radio information you should call through to
> > the "802.11 radio" dissector (so that it shows the radio information
> > in a pseudo-header-independent format) and pass along information to
> > let it know that *it* shouldn't call through to the 802.11 frame
> > dissector.
> 
> Tcpdump would also need to be changed not to call ieee802_11_print()
> at the end of ieee802_11_radio_print() in print-802_11.c - just return
> "len" for 0-length PPDUs.

Yes, both good points. Thanks!

johannes