Re: A modified, and maybe final, proposal for an S1G header for RadioTap

Johannes Berg <[email protected]> Tue, 02 Feb 2021 21:59:57 +0100
Newsgroups org.netbsd.radiotap
Message-ID <[email protected]>
Hi Richard,

Couple of (last-minute!) comments ...

> Structure
> : u16 known, u16 data1, u16 data2, u8 ndp_type, u8[5] ndp_data;
> 
> Required Alignment
> : 4

If you only have u16 data, what's the value of 4-byte alignment?

> Is NDP indicates that this is an NDP frame, however, the content might
> not be known.

Should that have a note that the zero-length PSDU field should be set?
But if so, should that get a new sub-type for S1G NDP?

Otherwise:

> > **`0x0080`** | Is NDP, which means no packet data follows this header! |

this overlaps?

I guess it doesn't really matter though if that overlaps.

> > **`0x00C0`** | Number spatial streams: 0=1 Spatial stream, 1=2, ..
> 3=4 Spatial streams |

"Number of" I guess

johannes