Re: EHT NSS units question

Johannes Berg <[email protected]> Wed, 24 Jul 2024 12:58:00 +0200
Newsgroups org.netbsd.radiotap
Message-ID <[email protected]>
On Thu, 2024-07-18 at 06:58 -0700, Ben Greear wrote:
> Hello,
>=20
> I would like to know if the units for NSS for EHT user element
> are zero based (ie, 0x0 means 1NSS) or ones-based (0x1 means 1NSS).
>=20
>  From what I can tell, wireshark is using zero based counting, but
> mt76 driver is using ones-based counting when filling in the radiotap hea=
der.
>=20
> I am not sure which one to fix...
>=20

Looks like we never fully defined this ... Arguably having 4 bits means
that we intended to have 1-8 (and perhaps 0 mean "unknown"), but having
another bit for "I knew the NSS" kind of made that unnecessary ...

But since both wireshark and iwlwifi agree to have 0=3D1NSS and 1=3D2NSS I
guess it's better to clarify that in the spec and fix mt76.

johannes