Re: [PATCH v3 19/51] exec/breakpoint: Return the new bp from cpu_breakpoint_insert

On 7/10/26 22:53, Richard Henderson wrote:
> The cpu_breakpoint_insert function cannot fail, so the error
> return value isn't actually used.  Instead of returning the
> new breakpoint by reference, return it directly.
> 
> Signed-off-by: Richard Henderson <[email protected]>
> ---
>   include/exec/breakpoint.h           |  4 ++--
>   accel/tcg/tcg-accel-ops.c           |  7 ++-----
>   cpu-common.c                        | 11 +++--------
>   gdbstub/user.c                      |  8 ++------
>   linux-user/main.c                   |  2 +-
>   target/arm/tcg/debug.c              |  2 +-
>   target/i386/tcg/system/bpt_helper.c |  3 +--
>   target/ppc/cpu.c                    |  2 +-
>   target/riscv/debug.c                |  5 ++---
>   target/xtensa/dbg_helper.c          |  6 +++---
>   10 files changed, 18 insertions(+), 32 deletions(-)

Reviewed-by: Ilya Leoskevich <[email protected]>