Re: [PATCH v3 21/51] exec/breakpoint: Return the new wp from cpu_watchpoint_insert
Ilya Leoshkevich <[email protected]>
| Newsgroups | org.nongnu.qemu-arm,org.nongnu.qemu-devel,org.nongnu.qemu-riscv |
|---|---|
| Message-ID | <[email protected]> |
On 7/10/26 22:53, Richard Henderson wrote: > The cpu_watchpoint_insert function cannot fail, so the error > return value isn't actually used. Instead of returning the > new watchpoint by reference, return it directly. > > Signed-off-by: Richard Henderson <[email protected]> > --- > include/exec/breakpoint.h | 5 ++--- > accel/tcg/tcg-accel-ops.c | 9 ++------- > accel/tcg/user-exec-stub.c | 7 +++---- > system/watchpoint.c | 11 +++-------- > target/arm/tcg/debug.c | 4 ++-- > target/i386/tcg/system/bpt_helper.c | 20 ++++++++------------ > target/ppc/cpu.c | 4 ++-- > target/riscv/debug.c | 28 +++++++++------------------- > target/s390x/tcg/debug.c | 10 +++++----- > target/xtensa/dbg_helper.c | 10 +++------- > 10 files changed, 39 insertions(+), 69 deletions(-) Reviewed-by: Ilya Leoshkevich <[email protected]>