Re: [PATCH 0/1] imx_serial: add missing migration state
Peter Maydell <[email protected]>
| Newsgroups | org.nongnu.qemu-arm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <CAFEAcA8AHg2Sov8rEsU1jNFYUgmBaVV7eBz0YtzExwHTLYvdEw@mail.gmail.com> |
On Wed, 15 Jul 2026 at 14:18, Tao Ding <[email protected]> wrote: > > Hi all. > The imx_serial is missing a migration status, > resulting in no display on the terminal after migration. > This patch fixes this issue. Whoops. Yes, ucr2 has the rx enable and tx enable bits, so not migrating it will leave the UART in a completely broken state. I've applied this patch to target-arm.next for 11.1. I tweaked the commit message a bit to lead off with a clearer description of the problem and to note that it's a migration compat break: The imx_serial vmstate is missing the ucr2 field. This register includes important state like the transmit enable and receive enable bits, so it's likely that after a migration the UART will be in a completely broken state. This bug has been present ever since the UART code was first added to QEMU. Add ucr2 from imx_serial to vmstate, and increment the version_id. This is a migration compatibility break, but this UART is only used in the various imx-based boards, where we are OK with compat breaks. [etc] thanks -- PMM