Re: [PATCH] Revert "target/arm: Build cpu32-system.o as common object"

On 20/7/26 12:03, Peter Maydell wrote:
> In c8bea1276c we moved cpu32.c and built it as a common object.  The
> commit message says "cpu32.c only contains CPU types used in 32-bit
> system emulation".  However, this is incorrect -- it contains 32-bit
> CPU types used in both system and usermode emulation.  (The case
> where we don't need these CPUs and which we were using ifdefs to
> avoid is specifically the AArch64 usermode qemu-aarch64 binary.)
> 
> The effect is that qemu-arm lost all the named CPU types except
> the M-profile ones (which are in cpu-v7m.c).
> 
> This reverts commit c8bea1276c85855b2e088b740737d043c8556d58.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3962
> Signed-off-by: Peter Maydell <[email protected]>
> ---
> The commit reverts cleanly, and looking at the git history
> I don't think we have anything that depends on it, so a simple
> revert seems best to me, especially given that cpu32-system.c
> doesn't reflect the fact that we do need these CPUs in
> usermode too.
> ---
>   target/arm/tcg/{cpu32-system.c => cpu32.c} | 10 +++++++++-
>   target/arm/tcg/meson.build                 |  5 ++++-
>   2 files changed, 13 insertions(+), 2 deletions(-)
>   rename target/arm/tcg/{cpu32-system.c => cpu32.c} (99%)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

Thanks.