Re: [PATCH v7] target/arm: Always add pmu property for host and max

Peter Maydell <[email protected]> Mon, 27 Jul 2026 17:10:11 +0100
Newsgroups org.nongnu.qemu-arm,org.kernel.vger.kvm,org.nongnu.qemu-devel
Message-ID <CAFEAcA-=u3ZgiAXRNWM1VCMv7FYG2YP=oirf40yGo--p0BSfbg@mail.gmail.com>
On Mon, 29 Jun 2026 at 09:10, Akihiko Odaki
<[email protected]> wrote:
>
> kvm-steal-time and sve properties are added for KVM even if the
> corresponding features are not available. Always add pmu property for
> "host" and "max".
>
> Note that we still don't add the property for other CPUs that lack PMU.
> This is because we do not know what a PMU version should be enabled
> when the user sets the property to true while it is defined as an error
> for the "host" or "max" CPU when the hardware accelerator is enabled and
> the host doesn't have a PMU.
>
> This fixes qtest-aarch64/arm-cpu-features on the hosts that supports
> KVM but doesn't support PMU emulation.

No, we should not special case "host" and "max" like this.
The "pmu" property exists only if the CPU has a PMU and it can
be turned off. If The arm-cpu-features test assumes that the
host CPU always has a PMU and so always has the property, then
that's a bug in the test, not in the code handling the property.

-- PMM