Re: [PATCH 0/3] hw/display/exynos4210_find: Clamp windows to screen

Peter Maydell <[email protected]> Tue, 28 Jul 2026 11:39:21 +0100
Newsgroups org.nongnu.qemu-arm,org.nongnu.qemu-devel
Message-ID <CAFEAcA8krc1OoZOxfhjcBVW-pY8MVX1e0gQGa=YGRVAtOLU_GA@mail.gmail.com>
On Tue, 28 Jul 2026 at 11:08, Marc-André Lureau
<[email protected]> wrote:
>
> On Mon, Jul 6, 2026 at 9:33 PM Peter Maydell <[email protected]> wrote:
> >
> > The exynos4210_fimd device has a setup where the guest can program
> > both the overall size of the LCD screen and also the corners of
> > "windows" that define where the guest memory should appear on that
> > screen. The current code assumes that the guest is sensible and
> > puts the corners of windows inside the overall screen. If it doesn't
> > then we will try to copy data to an address that is outside the
> > interfal framebuffer memory that we allocate to be the size of the
> > screen.
> >
> > This patchset clamps the window coordinates to be within the screen
> > size. Patches 1 and 2 are simple refactorings to make the third
> > patch easier to read.
> >
> > This fixes https://gitlab.com/qemu-project/qemu/-/work_items/3795
>
> Reviewed-by: Marc-André Lureau <[email protected]>

Thanks for the review; I've applied this series to target-arm.next.

-- PMM