Re: [PATCH 4/8] hw/sensor: update adm1266 block transfers

On Thu, 30 Jul 2026 at 00:13, Titus Rwantare <[email protected]> wrote:
>
> Fixes an issue with reading the MFR_* registers on the ADM1266, this
> device has an unconventional access pattern where a block write of
> length 1 is written to the MFR_* register with the length of the data
> to be read back. Simultaneously, it is possible to write to the contents
> of these registers so long as the block write is longer than 1.
>
> Signed-off-by: Titus Rwantare <[email protected]>

>  typedef struct ADM1266State {
>      PMBusDevice parent;
> +    uint8_t read_length;
>
>      char mfr_id[32];
>      char mfr_model[32];
>      char mfr_rev[8];
> +    char mfr_location[48];
> +    char mfr_date[16];
> +    char mfr_serial[32];

This patch seems to be doing two things at once:
(1) fix the semantics of the accesses to the MFR registers
(2) add missing location/date/serial registers

Please split it so we do these things in separate patches.
(Notably, part (2) depends on patch 3 in this series, but
I think a fix to (1) does not; we might want to mark the
bugfix part for backports to stable.)

thanks
-- PMM