RE: [PATCH v2 06/17] tests/qtest/aspeed-hace: Test the crypto command on the AST1030

> -----Original Message-----
> From: Jamin Lin <[email protected]>
> Sent: Wednesday, July 15, 2026 11:33 AM
> To: Daniel P. Berrangé <[email protected]>; Cédric Le Goater
> <[email protected]>; Peter Maydell <[email protected]>; Steven Lee
> <[email protected]>; Troy Lee <[email protected]>; Kane Chen
> <[email protected]>; Andrew Jeffery
> <[email protected]>; Joel Stanley <[email protected]>; Eric Blake
> <[email protected]>; Markus Armbruster <[email protected]>; Fabiano
> Rosas <[email protected]>; Laurent Vivier <[email protected]>; Paolo Bonzini
> <[email protected]>; open list:All patches CC here
> <[email protected]>; open list:ASPEED BMCs
> <[email protected]>
> Cc: Jamin Lin <[email protected]>; Troy Lee
> <[email protected]>
> Subject: [PATCH v2 06/17] tests/qtest/aspeed-hace: Test the crypto command
> on the AST1030
> 
> The AST1030 reuses the AST2600 crypto engine, so it drives the same
> scatter-gather transfers and supports the same ECB/CBC/CTR modes. Reuse
> the crypto known-answer tests to cover it, registering the AST1030 with the
> same modes and scatter-gather flag as the AST2600.
> 
> Signed-off-by: Jamin Lin <[email protected]>
> ---
>  tests/qtest/aspeed_hace-test.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspeed_hace-test.c
> index 61a3e3feb5..42130df1e2 100644
> --- a/tests/qtest/aspeed_hace-test.c
> +++ b/tests/qtest/aspeed_hace-test.c
> @@ -210,6 +210,12 @@ int main(int argc, char **argv)
>      qtest_add_func("ast1030/hace/sha384_accum",
> test_sha384_accum_ast1030);
>      qtest_add_func("ast1030/hace/sha256_accum",
> test_sha256_accum_ast1030);
> 
> +    /* The AST1030 reuses the AST2600 crypto engine (scatter-gather, CTR).
> */
> +    aspeed_add_crypto_tests("ast1030", "-machine ast1030-evb",
> 0x7e6d0000,
> +                            0x00000000,
> +                            CRYPT_MODE_ECB | CRYPT_MODE_CBC |
> CRYPT_MODE_CTR,
> +                            true);
> +
>      qtest_add_func("ast2600/hace/addresses", test_addresses_ast2600);
>      qtest_add_func("ast2600/hace/sha512", test_sha512_ast2600);
>      qtest_add_func("ast2600/hace/sha384", test_sha384_ast2600);
> --
> 2.43.0

Reviewed-by: Kane Chen <[email protected]>