Re: [PATCH v2 01/10] target/arm: Tidy cpu_max_initfn

On 12/8/26 22:44, Richard Henderson wrote:
> Once we have eliminated hwaccel_enabled, only tcg and qtest remain.
> Separate tcg from qtest initialization.  Remove an assert on
> aarch64_enabled that is directly protected by a preceding if.
> 
> Signed-off-by: Richard Henderson <[email protected]>
> ---
>   target/arm/cpu-max.c | 39 +++++++++++++++++++++------------------
>   1 file changed, 21 insertions(+), 18 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

> +    /* Ultimate fallback: -cpu max as cortex-a57. */
> +    assert(qtest_enabled());
> +    aarch64_aa32_a57_init(obj, !aarch64_enabled);

IIRC there is not CPU in QTest. I suppose we are just testing the
CLI, so "-cpu max" doesn't barf.

>   }
>   
>   static const ARMCPUInfo arm_max_cpu = {