Re: [PATCH v2 2/3] target/arm: Fix SVE2 WHILEWR/WHILERW zero diff boundary case

On 8/17/26 09:37, Peter Maydell wrote:
>> +    tcg_gen_addi_i64(diff, diff, -1);
>> +    tcg_gen_umin_i64(diff, diff, tcg_constant_i64((vsz >> a->esz) - 1));
>> +
>> +    /*
>> +     * Since we're bounded, pass as a 32-bit type.
>> +     * Sink the diff += 1 from above into the 32-bit type.
> 
> Is it worth doing that? Hosts are all 64-bits now, and surely there's
> not going to be a perf or codesize difference between "add 1"
> on a 32-bit type vs a 64-bit type ?
Technically one byte difference on x86_64.
But we could drop the whole truncation thing it you like.


r~