RE: [PATCH v1 5/8] hw/misc/aspeed_sbc: Support the ECDSA verify command

Hi Cédric

> > a/include/hw/misc/aspeed_sbc.h b/include/hw/misc/aspeed_sbc.h index
> > 07c7c22a86..9b04a10aed 100644
> > --- a/include/hw/misc/aspeed_sbc.h
> > +++ b/include/hw/misc/aspeed_sbc.h
> 
> Please add to your .git/config :
> 
>    [diff]
> 	  orderFile = /path/to/qemu/scripts/git.orderfile
> 
> 
> 

Recently reinstalled my Ubuntu working environment and forgot to add this setting back to my Git config.
Sorry that you had to remind me about this review rule several times.

Thanks,
Jamin.

> > @@ -40,12 +40,17 @@ struct AspeedSBCState {
> >       uint32_t regs[ASPEED_SBC_NR_REGS];
> >
> >       AspeedOTPState otp;
> > +
> > +    MemoryRegion *sram;
> > +    AddressSpace sram_as;
> > +    uint64_t sram_base;
> 
> See comment on
> 
> https://lore.kernel.org/qemu-devel/20260813062359.425268-2-jamin_lin@asp
> eedtech.com/#t
> 
> Thanks,
> 
> C.
> 
> 
> >   };
> >
> >   struct AspeedSBCClass {
> >       SysBusDeviceClass parent_class;
> >
> >       bool has_otp;
> > +    bool has_ecdsa;
> >   };
> >
> >   #endif /* ASPEED_SBC_H */