Re: [PATCH 3/5] hw/arm: Remove the 'musicpal' machine
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | org.nongnu.qemu-arm,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On 19/8/26 20:54, Peter Maydell wrote:
> The 'musicpal' machine emulates the Freecom MusicPal, which was an
> "internet radio" released in the mid-2000s. The stock system used a
> 2.6.16 Linux kernel, but as far as I'm aware, support for the
> hardware was never upstreamed to the mainline kernel.
>
> There are a number of reasons for deprecating this board:
> * The hardware is now solidly obsolete
> * It was never supported in mainline Linux
> * The SoC is a Marvell one with no public datasheet
> * The only QEMU changes to it have been the usual tree wide
> updates and refactoring work
> * The only bug report we've ever had about it has been one of
> the usual "bug found by static analysis" kind
>
> But in fact we can just drop it immediately, because in commit
> 59754f85ed35 ("target/arm: Do memory type alignment check when
> translation disabled") in 2024 we broke the boot of the standard
> firmware image for this board. (The image's u-boot does a LDRH to an
> unaligned address, which is UNPREDICTABLE; we used to let it through,
> but that commit makes it take a Data Abort, so the image crashes
> before it boots the kernel.) Since nobody complained, we can deduce
> that nobody's actually using this machine.
>
> Remove the machine proper, and note this in the docs. Devices used
> only by this board will be removed in subsequent commits.
>
> Signed-off-by: Peter Maydell <[email protected]>
> ---
> MAINTAINERS | 10 -
> configs/devices/arm-softmmu/default.mak | 1 -
> docs/about/removed-features.rst | 10 +
> docs/system/arm/musicpal.rst | 19 -
> docs/system/target-arm.rst | 1 -
> hw/arm/Kconfig | 12 -
> hw/arm/meson.build | 1 -
> hw/arm/musicpal.c | 1388 -----------------------
> 8 files changed, 10 insertions(+), 1432 deletions(-)
> delete mode 100644 docs/system/arm/musicpal.rst
> delete mode 100644 hw/arm/musicpal.c
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>