Re: [PATCH 1/5] tests/qtest/pflash-cfi02-test: Don't use musicpal machine for testing

On 19/8/26 20:54, Peter Maydell wrote:
> We currently use the musicpal machine for testing the pflash-cfi02
> device.  We'd like to remove that machine, so switch the tests to the
> sh4 r2d board type instead.
> 
> We use r2d because it happens to have the same "2 bank" config that
> musicpal did.  (Of our other options, xilinx-zynq-a9 has only a
> 1-bank setup so wouldn't allow the same range of testing, and the
> canon-a1100 board both doesn't support specifying a flash drive via
> -drive if=pflash, plus it seems likely it too might be a candidate
> for deprecate-and-drop.)
> 
> The r2d flash device is not quite the same config as the musicpal
> one: it has a different base address and size, and different
> ID values. So we need to update the test to match.
> 
> Signed-off-by: Peter Maydell <[email protected]>
> ---
>   tests/qtest/meson.build         |  6 +++---
>   tests/qtest/pflash-cfi02-test.c | 38 ++++++++++++++++++++-------------
>   2 files changed, 26 insertions(+), 18 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>