Re: [PATCH v2 44/50] target/hexagon: Keep gen_slotval/check_noshuf for helper-to-tcg

On Thu, 30 Jul 2026 05:10:18 +0200
Anton Johansson via qemu development <[email protected]> wrote:

> diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
> index 3ce223caba..1a067cd1ce 100644
> --- a/target/hexagon/op_helper.c
> +++ b/target/hexagon/op_helper.c
> @@ -488,7 +488,7 @@ void HELPER(probe_pkt_scalar_hvx_stores)(CPUHexagonState *env, int mask)
>      }
>  }
>  
> -#ifndef CONFIG_HEXAGON_IDEF_PARSER
> +#if !defined(CONFIG_HEXAGON_IDEF_PARSER) || defined(CONFIG_HELPER_TO_TCG)
>  /*
>   * mem_noshuf
>   * Section 5.5 of the Hexagon V67 Programmer's Reference Manual

This change prevents me from building with
`-Dhexagon_helper_to_tcg=disabled`.

Maybe I'm doing something wrong.

-- 
Alessandro Di Federico
rev.ng Labs