Re: [PATCH] hw/display/virtio-gpu: drop redundant node->value NULL checks

Akihiko Odaki <[email protected]> Sat, 1 Aug 2026 21:05:57 +0900
Newsgroups org.nongnu.qemu-devel
Message-ID <[email protected]>
On 2026/07/30 20:47, [email protected] wrote:
> From: Marc-AndrĂ© Lureau <[email protected]>
> 
> QAPI-generated list visitors guarantee that node->value is never NULL:
> the input visitor allocates it via g_malloc0() in visit_start_struct(),
> and on failure the entire list parse is aborted and freed.
> 
> Remove the unnecessary NULL checks from both callsites iterating
> g->conf.outputs.
> 
> Resolves: Coverity CID 1664272
> Fixes: 8dc8449a678f ("hw/display/virtio-gpu: Avoid leaking migration blocker")
> Signed-off-by: Marc-AndrĂ© Lureau <[email protected]>

Reviewed-by: Akihiko Odaki <[email protected]>

Regards,
Akihiko Odaki