Re: [PATCH 4/6] hw/nvme: Fix block accounting for compare

Klaus Jensen <[email protected]> Mon, 3 Aug 2026 06:51:31 -0700
Newsgroups org.nongnu.qemu-devel
Message-ID <[email protected]>
--D5YHw7M7scoCz2Yc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul 29 14:44, Klaus Jensen wrote:
> On Jul 24 17:23, Hanna Czenczek wrote:
> > nvme_compare() starts block accounting for the operation, but
> > nvme_compare_data_cb() (and nvme_compare_mdata_cb()) do not always
> > finalize the cookie.  Specifically, there are a lot of error paths that
> > do not call block_acct_failed().
> >=20
> > Fix this by putting block_acct_done()/block_acct_failed() under the
> > `out` labels of nvme_compare_data_cb() and nvme_compare_mdata_cb().
> >=20
> > Signed-off-by: Hanna Czenczek <[email protected]>
>=20
> Reviewed-by: Klaus Jensen <[email protected]>
>=20

Will this make it for 11.1? Otherwise, I'd like to grab the two nvme
related patches in my pull.

Thanks,
Klaus

--D5YHw7M7scoCz2Yc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmpwnOMACgkQTeGvMW1P
DemvawgAkq6yfnrAnBlbyRnBCnE6vthrkb8DuX/js1qYdlG+B61amoUL5hRjADPX
VfXEjQFqJfmysYpnyPQuhek2VwwXFucWFgrwsKp72MU2b7bulzcfansLup5fchX/
tinw9+T/AYr7JZy4sELhJeMafzimJf17YYgE4tqMxqT0RrI//USeXgNZmBYu99dr
PoIwkstdDJTa6PriaK3+jM8krFzgshfmkHagSBfMvj5wus3s0q5Ia/mSuHS1A2i8
kVydaRQ2EhfSqpvqtzW+3A0yJx4XiDhhaYL48tpuCM938equbhTYQFGuPntpyYnk
rRU1lIAVclVbR0qfVrMe4NsYTo45Tw==
=Ubum
-----END PGP SIGNATURE-----

--D5YHw7M7scoCz2Yc--