Re: [PATCH] linux-user: Fix msqid_ds struct wrt 32-bit big endian architectures

Peter Maydell <[email protected]>
Newsgroups org.nongnu.qemu-devel
Message-ID <CAFEAcA8Mof1EDHoF0hBRcu+to0W6ny-KvX7mUwch+SGVgRD3MA@mail.gmail.com>
On Tue, 4 Aug 2026 at 07:30, Helge Deller <[email protected]> wrote:
>
> On 8/3/26 23:42, Andreas Schwab wrote:
> >  This "preferred" approach does not really make any sense at all.
>
> Right. IMHO this "preferred" (aka padding behind 32-bit time value even on big-endian)
> doesn't make any sense for big-endian. The lower 32-bit value then ends up in the upper
> 32-bits of a 64-bit time_t value and thus you have problems when mixing 32- and 64-bit
> time_t applications.
> I think m68k needs to follow the other 32-bit big-endian arches I mentioned above
> and provide an own uapi/asm/msgbuf.h:struct msqid64_ds file/struct.
> And this stupid "preferred" sentence in the kernel should be dropped.

If every 32-bit big-endian architecture is avoiding the asm-generic
msqid64_ds struct in order to provide its own, and they are all
exactly the same, could the asm-generic one be made to do what all the
32-bit BE archs actually want rather than something that nobody wants?

-- PMM
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.