Re: [PATCH v6 097/103] tests/tcg: remove remaining Makefiles

On 8/12/2026 7:27 AM, Alex Bennée wrote:
> Pierrick Bouvier <[email protected]> writes:
> 
>> tests/tcg/mips/user/ has extra tests that are not currently run at the
>> moment. Keep their Makefiles until they are implemented.
>>
>> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>> Signed-off-by: Pierrick Bouvier <[email protected]>
> <snip>
>> -else
>> -# For system targets we include a different Makefile fragment as the
>> -# build options for bare programs are usually pretty different. They
>> -# are expected to provide their own build recipes.
>> -EXTRA_CFLAGS += -ffreestanding -fno-stack-protector
>> -
> 
> Ahh here is where -ffreestanding came in. We should also check why
> -fno-stack-protector was added.
> 

I removed flags that didn't expose any difference in test
compilation/results, thus skipped -ffreestanding and -fno-stack-protector.

For -fno-stack-protector, I don't see any good reason to have it. In
worst case, there is a compiler that adds SSP by default and it breaks a
specific test, and it would be a good idea to document that on concerned
test, instead of globally applying the flag.

Regards,
Pierrick