Re: [PATCH v6 097/103] tests/tcg: remove remaining Makefiles

On 8/12/2026 12:47 PM, Alex Bennée wrote:
> Pierrick Bouvier <[email protected]> writes:
> 
> (Add Akihiko to Cc)
> 
>> On 8/12/2026 8:57 AM, Pierrick Bouvier wrote:
>>> On 8/12/2026 7:27 AM, Alex Bennée wrote:
>>>> Pierrick Bouvier <[email protected]> writes:
>>>>
>>>>> tests/tcg/mips/user/ has extra tests that are not currently run at the
>>>>> moment. Keep their Makefiles until they are implemented.
>>>>>
>>>>> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>>>>> Signed-off-by: Pierrick Bouvier <[email protected]>
>>>> <snip>
>>>>> -else
>>>>> -# For system targets we include a different Makefile fragment as the
>>>>> -# build options for bare programs are usually pretty different. They
>>>>> -# are expected to provide their own build recipes.
>>>>> -EXTRA_CFLAGS += -ffreestanding -fno-stack-protector
>>>>> -
>>>>
>>>> Ahh here is where -ffreestanding came in. We should also check why
>>>> -fno-stack-protector was added.
>>>>
>>>
>>
>> https://gitlab.com/qemu-project/qemu/-/commit/580731dcc87eb27a2b0dc20ec331f1ce51864c97
>>
>> It seems like a specific setup on a specific machine will have specific
>> requirements. Not sure it should become the norm, but if you prefer, I
>> can just replicate the existing flags, and we can call it a day.
> 
> Was this a particular GCC build or the default for all GCC's post 13.2?
>

I have the impression it's the particular build he used. Else a distro
name would have been mentioned.

I still think it would make more sense to have this flag per test when
it's mandatory. Maybe we can just let people with custom compilers
discover where it's needed?
>>
>> Let me know what you'd prefer.
>>  Regards,
>> Pierrick
>