Re: [PATCH v3 02/23] net/vhost-vdpa: Include missing 'qemu/iov.h' header
| Newsgroups | org.nongnu.qemu-devel |
|---|---|
| Message-ID | <178660214824.3552881.7884123985702160626.b4-review@b4> |
On Wed, 12 Aug 2026 23:16:46 +0200, Philippe Mathieu-Daudé <[email protected]> wrote: > vhost-vdpa.c uses methods declared in the "qemu/iov." header. > Include it otherwise we get when refactoring unrelated headers: > > ../net/vhost-vdpa.c: In function ‘vhost_vdpa_net_load_cmd’: > ../net/vhost-vdpa.c:714:24: error: implicit declaration of function ‘iov_size’ > 714 | size_t data_size = iov_size(data_sg, data_num), cmd_size; > | ^~~~~~~~ > ../net/vhost-vdpa.c:714:24: error: nested extern declaration of ‘iov_size’ > ../net/vhost-vdpa.c:742:5: error: implicit declaration of function ‘iov_from_buf’ > 742 | iov_from_buf(out_cursor, 1, 0, &ctrl, sizeof(ctrl)); > | ^~~~~~~~~~~~ > ../net/vhost-vdpa.c:742:5: error: nested extern declaration of ‘iov_from_buf’ > ../net/vhost-vdpa.c:744:5: error: implicit declaration of function ‘iov_to_buf’ > 744 | iov_to_buf(data_sg, data_num, 0, > | ^~~~~~~~~~ > ../net/vhost-vdpa.c:744:5: error: nested extern declaration of ‘iov_to_buf’ > ../net/vhost-vdpa.c:748:5: error: implicit declaration of function ‘iov_copy’ > 748 | iov_copy(&out, 1, out_cursor, 1, 0, cmd_size); > | ^~~~~~~~ > > [...] Reviewed-by: Marc-André Lureau <[email protected]> -- Marc-André Lureau <[email protected]>