Re: [PATCH v2 0/6] qom: tidy-ups and preparation for class property conversion

On Thu, 13 Aug 2026 at 17:42, Mark Cave-Ayland
<[email protected]> wrote:
>
> On 13/08/2026 11:38, Daniel P. Berrangé wrote:
>
> > On Fri, Jul 17, 2026 at 02:51:40PM +0100, Mark Cave-Ayland wrote:
> >> Based upon feedback from my existing efforts to start converting from object
> >> properties to class properties, here is an initial preparation series which
> >> I hope can be applied soon after 11.1 is released.
> >
> > IMHO this version is suitable for merge and could be include as part of a
> > general tree-wide PULL that does a broader set of class property conversions,
> > unless Paolo really wants to queue it in a dedicated QOM series.
> Thanks Daniel. In theory I could send a PR for this, however I'm unsure
> as to how to handle that my current signed GPG key is for a different
> email address from my work email address which is where the series
> originated.
>
> Does anyone in a similar situation have an idea as to how best to handle
> this?

What we care about for signed pull requests is that the identity who
signed the pull request has a GPG key that the person processing
pullrequests knows about. The email address used as the author
address on the patches/commits doesn't matter.

You can either:

(1) send a pullreq where the tag is signed by your personal address's
GPG key, as you have been doing up til now. (I mention this mostly for
completeness: if you expect to be doing QEMU work including compiling
and sending pull requests on work time you probably want to do that
labelled up under your work address.)

(2) update your existing GPG key to add your work address to it,
upload that key to the keyservers, and tell us that we should update;
then send a pullreq signed by the key from your work address.

(3) create a brand new separate GPG key with your work address,
sign your new work key with your personal GPG key, upload the signed
key to the keyservers, and tell us that we should update; then send a
pullreq signed by your work key from your work address.

In any of these cases, if you're sending the pullreq as an
identity that isn't the same as the one that authored the patches,
you should add a signed-off-by line for you-as-pullreq-submitter
to each commit, just as you would for any other contributor's patch
that you're putting into a pullreq. Nothing checks this or fails if
you don't do it, it's just a bit of bookkeeping that tracks "this
thing from me with one hat on went through a pullreq handled by me
with my other hat on".

I have no opinion about whether (2) or (3) is preferable here.
I think (looking at 'gpg --list-keys' output) that generally
people add both work and personal IDs to a single GPG key, but
I don't know GPG well enough to know if this has downsides.

thanks
-- PMM