Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

On 26/9/23 08:51, Markus Armbruster wrote:
> Paolo Bonzini <[email protected]> writes:
> 
>> On 9/25/23 13:03, Markus Armbruster wrote:
>>> +David
>>> Markus Armbruster <[email protected]> writes:
>>>
>>>> Philippe Mathieu-Daudé <[email protected]> writes:
>>>>
>>>>> DEFINE_PROP_DMAADDR() is only used once. Since it doesn't
>>>>> add much value, simply remove it, along with the header
>>>>> defining it.
>>>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
>>>>
>>>> DEFINE_PROP_DMAADDR() lets you wrap a property around a dma_addr_t
>>>> member without assuming anything about dma_addr_t.
>>>>
>>>> Whether that's worth avoiding I can't say.  Depends on how much the
>>>> abstraction leaks in other ways.  Thoughts?
>>
>> I think it's okay to simplify things.  If anybody ever has a reason to make dma_addr_t variable sized (probably a bad idea because many of its users are compiled once only) they have one extra place to fix.  Tough luck. :)
> 
> Makes sense.
> 
> Reviewed-by: Markus Armbruster <[email protected]>

Thanks, I'm queuing this single patch via my hw-misc tree.