Re: [PATCH 06/10] hw/sd: sdhci: Honor i.MX uSDHC vendor clock gates

On 12/8/26 03:36, Bin Meng wrote:
> U-Boot's i.MX uSDHC driver enables IPGEN, HCKEN, PEREN and CKEN in
> VEND_SPEC rather than the standard SDHCI clock-control fields. QEMU
> only checks the standard fields before issuing a command. It therefore
> silently drops U-Boot's MMC commands even though the controller clocks
> are enabled. U-Boot eventually times out waiting for command completion
> and cannot load the kernel and device tree from the SD card.
> 
> Accept the complete vendor clock-gate set as another valid clock source
> for i.MX uSDHC. Also report SDSTB when the vendor IP and host clocks
> are enabled, matching the state U-Boot polls while changing the clock.
> 
> Keep this behavior behind an i.MX uSDHC quirk because the shared eSDHC
> paths also serve controllers which use the standard SDHCI fields.
> 
> Reference: IMX6ULRM (Rev 2), section 56.8.10, 56.8.12 and 56.8.26
> https://www.nxp.com/webapp/Download?colCode=IMX6ULRM
> 
> Signed-off-by: Bin Meng <[email protected]>
> ---
> 
>   hw/sd/sdhci.c         | 27 ++++++++++++++++++++++++---
>   include/hw/sd/sdhci.h |  7 ++++++-
>   2 files changed, 30 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>