Re: [PATCH v2 06/20] hw/arm: exynos4_boards: Store boot info in the board state
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | org.nongnu.qemu-devel,org.nongnu.qemu-arm |
|---|---|
| Message-ID | <[email protected]> |
On 16/8/26 15:12, Bin Meng wrote:
> arm_load_kernel() keeps a pointer to the boot info struct for the
> lifetime of the VM, so the struct logically belongs to the machine
> rather than to a file scoped static object.
>
> The Exynos4BoardState struct is already allocated per machine
> instance, so move the boot info there.
>
> As in the xlnx-zcu102 and raspi machines, the boot info belongs to
> the machine rather than to a static object:
>
> 4d1ac883a7 ("hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102")
> 0f15c6e338 ("hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState")
>
> Signed-off-by: Bin Meng <[email protected]>
> ---
>
> hw/arm/exynos4_boards.c | 26 +++++++++++---------------
> 1 file changed, 11 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>