Re: [PATCH v2] target/ppc: Add lower bound check for watchdogNumber

On 2026/08/18 02:40 PM, Chinmay Rath wrote:
> Add missing lower bound check for H_WATCHDOG H_CALL's watchdogNumber parameter
> as per PAPR documentation ver 12.10.00 section 14.15.5 'H_WATCHDOG'.
> 
> Closes : https://gitlab.com/qemu-project/qemu/-/work_items/3600
> Signed-off-by: Chinmay Rath <[email protected]>
> ---
> 
> Changes from v1 : Incorporated changes suggested by Amit.

Thanks for the quick v2 — the helper and the OP_STOP restructuring look
good. One remaining nit below.

> v1 : https://lore.kernel.org/qemu-devel/[email protected]/
> 
>  hw/watchdog/spapr_watchdog.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/watchdog/spapr_watchdog.c b/hw/watchdog/spapr_watchdog.c
> index 5b3f50de3a..460b4457a6 100644
> --- a/hw/watchdog/spapr_watchdog.c
> +++ b/hw/watchdog/spapr_watchdog.c
> @@ -127,6 +127,12 @@ static void watchdog_expired(void *pw)
>      }
>  }
>  
> +static inline bool watchdogNumber_valid(target_ulong watchdogNumber,

The function name watchdogNumber_valid mixes camelCase with snake_case.
Per the QEMU coding style (docs/devel/style.rst), CamelCase is reserved
for structured type names and typedefs — regular function names follow
lower_case_with_underscores. This should be watchdog_number_valid.

With that fixed:

Reviewed-by: Amit Machhiwal <[email protected]>

Thanks,
Amit