Re: [PATCH v3 06/74] meson: add qapi-type-infos-*.c/h to build

Reviewed-by: Kostiantyn Kostiuk <[email protected]>

On Tue, Aug 18, 2026 at 2:13 PM Marc-André Lureau <
[email protected]> wrote:

> Add the per-module type-infos output files so they are compiled into
> the build.
>
> Signed-off-by: Marc-André Lureau <[email protected]>
> ---
>  qapi/meson.build              | 4 ++++
>  qga/meson.build               | 2 ++
>  tests/include/meson.build     | 2 ++
>  tests/meson.build             | 6 ++++++
>  tests/qapi-schema/meson.build | 1 +
>  5 files changed, 15 insertions(+)
>
> diff --git a/qapi/meson.build b/qapi/meson.build
> index a46269b5a0c9..7477953492ad 100644
> --- a/qapi/meson.build
> +++ b/qapi/meson.build
> @@ -79,6 +79,7 @@ endif
>
>  qapi_nonmodule_outputs = [
>    'qapi-introspect.c', 'qapi-introspect.h',
> +  'qapi-type-infos.c', 'qapi-type-infos.h',
>    'qapi-types.c', 'qapi-types.h',
>    'qapi-visit.h', 'qapi-visit.c',
>    'qapi-commands.h', 'qapi-commands.c',
> @@ -88,6 +89,7 @@ qapi_nonmodule_outputs = [
>  ]
>
>  qapi_outputs = qapi_nonmodule_outputs + [
> +  'qapi-builtin-type-infos.c', 'qapi-builtin-type-infos.h',
>    'qapi-builtin-types.c', 'qapi-builtin-visit.c',
>    'qapi-builtin-types.h', 'qapi-builtin-visit.h',
>  ]
> @@ -96,6 +98,8 @@ qapi_inputs = []
>  foreach module : qapi_all_modules
>    qapi_inputs += [ files(module + '.json') ]
>    qapi_module_outputs = [
> +    'qapi-type-infos-@[email protected]'.format(module),
> +    'qapi-type-infos-@[email protected]'.format(module),
>      'qapi-types-@[email protected]'.format(module),
>      'qapi-types-@[email protected]'.format(module),
>      'qapi-visit-@[email protected]'.format(module),
> diff --git a/qga/meson.build b/qga/meson.build
> index cfa2157efb23..79163b7d8e93 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -39,6 +39,8 @@ qga_qapi_outputs = [
>    'qga-qapi-init-commands.h',
>    'qga-qapi-introspect.c',
>    'qga-qapi-introspect.h',
> +  'qga-qapi-type-infos.c',
> +  'qga-qapi-type-infos.h',
>    'qga-qapi-types.c',
>    'qga-qapi-types.h',
>    'qga-qapi-visit.c',
> diff --git a/tests/include/meson.build b/tests/include/meson.build
> index 8e8d1ec4e692..026480d96851 100644
> --- a/tests/include/meson.build
> +++ b/tests/include/meson.build
> @@ -4,6 +4,8 @@ test_qapi_outputs_extra = [
>    'test-qapi-commands-sub-module.h',
>    'test-qapi-events-sub-module.c',
>    'test-qapi-events-sub-module.h',
> +  'test-qapi-type-infos-sub-module.c',
> +  'test-qapi-type-infos-sub-module.h',
>    'test-qapi-types-sub-module.c',
>    'test-qapi-types-sub-module.h',
>    'test-qapi-visit-sub-module.c',
> diff --git a/tests/meson.build b/tests/meson.build
> index 9ba04bbedd30..71dc4ac8bf99 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -2,6 +2,8 @@ subdir('bench')
>  subdir('qemu-iotests')
>
>  test_qapi_outputs = [
> +  'qapi-builtin-type-infos.c',
> +  'qapi-builtin-type-infos.h',
>    'qapi-builtin-types.c',
>    'qapi-builtin-types.h',
>    'qapi-builtin-visit.c',
> @@ -22,6 +24,10 @@ test_qapi_outputs = [
>    'test-qapi-init-commands.h',
>    'test-qapi-introspect.c',
>    'test-qapi-introspect.h',
> +  'test-qapi-type-infos-sub-sub-module.c',
> +  'test-qapi-type-infos-sub-sub-module.h',
> +  'test-qapi-type-infos.c',
> +  'test-qapi-type-infos.h',
>    'test-qapi-types-sub-sub-module.c',
>    'test-qapi-types-sub-sub-module.h',
>    'test-qapi-types.c',
> diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build
> index debff633ac17..392b59d8dccd 100644
> --- a/tests/qapi-schema/meson.build
> +++ b/tests/qapi-schema/meson.build
> @@ -231,6 +231,7 @@ custom_target('QAPI doc',
>                         'doc-good-qapi-events.c', 'doc-good-qapi-events.h',
>                         'doc-good-qapi-init-commands.c',
> 'doc-good-qapi-init-commands.h',
>                         'doc-good-qapi-introspect.c',
> 'doc-good-qapi-introspect.h',
> +                       'doc-good-qapi-type-infos.c',
> 'doc-good-qapi-type-infos.h',
>                         'doc-good-qapi-types.c', 'doc-good-qapi-types.h',
>                         'doc-good-qapi-visit.c', 'doc-good-qapi-visit.h' ],
>                input: files('doc-good.json'),
>
> --
> 2.55.0.543.g5ebe2ebe4ea8
>
>