Re: [PATCH v2 4/5] target/hexagon: fix HVX predicate save size for histogram ops
Matheus Tavares Bernardino <[email protected]>
| Newsgroups | org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 20 Aug 2026 14:51:16 -0700 Brian Cain <[email protected]> wrote: > > The masked histogram instructions save the predicate operand to the qtmp > temporary with a gvec move sized sizeof(MMVector). Both source and > destination are MMQReg, which is eight times smaller, so the move read > 112 bytes past the predicate register and wrote them over the fields > following qtmp in CPUHexagonState, that is vstore[0]. Use the size of > the registers actually being copied. > > Signed-off-by: Brian Cain <[email protected]> > --- > target/hexagon/gen_tcg_hvx.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Matheus Tavares Bernardino <[email protected]>