Re: [PATCH v1] docs/vhost-user: clarify the semantics of VHOST_USER_SET_VRING_ENABLE
Vladimir Sementsov-Ogievskiy <[email protected]>
| Newsgroups | org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
ping. This old patch applies to master, and makes sense. Let's merge it. On 25.03.26 14:36, Daniil Tatianin wrote: > Documentation didn't really make it clear that the payload contains any > sort of desired state field, you could only derive that by looking at > the QEMU implementation of this request. Add an extra note to make that > clear. > > Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> > Signed-off-by: Daniil Tatianin <[email protected]> > --- > > Changes since v0: > - Remove 'Note that' (suggested by Vladimir) > > --- > docs/interop/vhost-user.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst > index 137c9f3669d..e29eb291f11 100644 > --- a/docs/interop/vhost-user.rst > +++ b/docs/interop/vhost-user.rst > @@ -1346,6 +1346,8 @@ Front-end message types > :reply payload: N/A > > Signal the back-end to enable or disable corresponding vring. > + The ``num`` field contains the target vring state where 0 means disabled, > + and any other value means enabled. > > This request should be sent only when > ``VHOST_USER_F_PROTOCOL_FEATURES`` has been negotiated. -- Best regards, Vladimir