Re: [PATCH] subprojects: re-include *.wrap files

Marc-André Lureau <[email protected]>
Newsgroups org.nongnu.qemu-devel
Message-ID <CAJ+F1CJe4x1Pne=57rUQ=HMdtzygLiWPOOsSMPXopNYDXWaO5Q@mail.gmail.com>
On Fri, Aug 21, 2026 at 10:48 AM Dominique Martinet
<[email protected]> wrote:
>
> The existing wrap files e.g. anyhow-1-rs.wrap are ignored because
> meson extract the sources in the subprojects directory
>
> This is not a problem for git itself, because files that had already
> been added are properly tracked, but tools such as fd-find blindly
> trust the ignore rules and fail to pick up the .wrap files, making
> discoverying the build system (when e.g. adding another crate or just
> curiosity) more difficult than necessary
>
> This added rule re-adds the wrap files so they now properly get picked
> up.
>
> Signed-off-by: Dominique Martinet <[email protected]>
> ---
> Stumbled upon this when looking at the rust build system out of
> curiosity (because stsquad asked something related on IRC)
>
> It probably doesn't matter much, but took me more time than it should
> have to find the wrap files, so might as well improve this for the next
> one to look at these.

Reviewed-by: Marc-André Lureau <[email protected]>

> ---
>  subprojects/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> index 011ce4dc3b77..4bdedb081601 100644
> --- a/subprojects/.gitignore
> +++ b/subprojects/.gitignore
> @@ -26,3 +26,6 @@
>
>  # Workaround for Meson v1.9.0 https://github.com/mesonbuild/meson/issues/14948
>  /.wraplock
> +
> +# re-include wrap files regardless of ignores above
> +!/*.wrap
>
> ---
> base-commit: acc271509ab015b9e064065f26d41a61e01e641b
> change-id: 20260821-subprojects-ignore-8a9460a6d7ad
>
> Best regards,
> --
> Dominique Martinet | Asmadeus
>
>


-- 
Marc-André Lureau
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.