[PATCH] target/riscv: Fix memory leak in riscv_trigger_unrealize()
Zeng Chi <[email protected]> Thu, 23 Jul 2026 17:59:11 +0800
| Newsgroups | org.nongnu.qemu-riscv,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <[email protected]> |
From: Zeng Chi <[email protected]> In riscv_trigger_unrealize(), the per-trigger QEMUTimer objects are created in riscv_trigger_realize() using timer_new_ns(). However, unrealize only calls timer_del() to cancel them, but never frees the timer objects themselves. This results in a memory leak every time a CPU instance is unrealized (e.g., during hot-unplug or machine teardown). Fix it by calling timer_free() for each timer after timer_del(). Fixes: 820552a92e32 ("target/riscv: dynamic alloc of debug trigger arrays") Signed-off-by: Zeng Chi <[email protected]> --- target/riscv/tcg/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/tcg/debug.c b/target/riscv/tcg/debug.c index 3c0fe70101..ffbdc17023 100644 --- a/target/riscv/tcg/debug.c +++ b/target/riscv/tcg/debug.c @@ -1081,6 +1081,7 @@ void riscv_trigger_unrealize(CPURISCVState *env) for (int i = 0; i < env->num_triggers; i++) { timer_del(env->itrigger_timer[i]); + timer_free(env->itrigger_timer[i]); } g_free(env->itrigger_timer); } -- 2.25.1 No virus found Checked by Hillstone Network AntiVirus