Re: [PATCH v2 5/7] hw/riscv: k230: add decomp gzip in K230 board

On 7/27/2026 12:57 PM, Tao Ding wrote:
> This commit replaces the unimplemented part of Decomp_gzip in K230.
> Connect to the handshake interface of GSDMA.
> 
> Signed-off-by: Tao Ding <[email protected]>
> Reviewed-by: Junze Cao <[email protected]>
> ---

Reviewed-by: Daniel Henrique Barboza <[email protected]>

>   hw/riscv/Kconfig        |  1 +
>   hw/riscv/k230.c         | 23 +++++++++++++++++++----
>   include/hw/riscv/k230.h |  2 ++
>   3 files changed, 22 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> index d28ac06043..d06ac26648 100644
> --- a/hw/riscv/Kconfig
> +++ b/hw/riscv/Kconfig
> @@ -163,3 +163,4 @@ config K230
>       select UNIMP
>       select K230_WDT
>       select K230_GSDMA
> +    select K230_DECOMP_GZIP
> diff --git a/hw/riscv/k230.c b/hw/riscv/k230.c
> index c80bd65694..7fd1ec4c25 100644
> --- a/hw/riscv/k230.c
> +++ b/hw/riscv/k230.c
> @@ -111,6 +111,8 @@ static void k230_soc_init(Object *obj)
>       object_initialize_child(obj, "k230-wdt0", &s->wdt[0], TYPE_K230_WDT);
>       object_initialize_child(obj, "k230-wdt1", &s->wdt[1], TYPE_K230_WDT);
>       object_initialize_child(obj, "k230-gsdma", &s->gsdma, TYPE_K230_GSDMA);
> +    object_initialize_child(obj, "k230-decomp-gzip", &s->decomp_gzip,
> +                            TYPE_K230_DECOMP_GZIP);
>   
>       qdev_prop_set_uint32(DEVICE(cpu0), "hartid-base", 0);
>       qdev_prop_set_string(DEVICE(cpu0), "cpu-type", TYPE_RISCV_CPU_THEAD_C908);
> @@ -215,6 +217,23 @@ static void k230_soc_realize(DeviceState *dev, Error **errp)
>       sysbus_connect_irq(SYS_BUS_DEVICE(&s->gsdma), 0,
>                          qdev_get_gpio_in(DEVICE(s->c908_plic), K230_GSDMA_IRQ));
>   
> +    /* Decomp gzip */
> +    qdev_prop_set_uint64(DEVICE(&s->decomp_gzip), "sram-base",
> +                         memmap[K230_DEV_SRAM].base);
> +    if (!sysbus_realize(SYS_BUS_DEVICE(&s->decomp_gzip), errp)) {
> +        return;
> +    }
> +    sysbus_mmio_map(SYS_BUS_DEVICE(&s->decomp_gzip), 0,
> +                    memmap[K230_DEV_DECOMP_GZIP].base);
> +    for (int i = 0; i < K230_DECOMP_GZIP_NUM_GPIOS_OUT; i++) {
> +        qdev_connect_gpio_out(DEVICE(&s->decomp_gzip), i,
> +                              qdev_get_gpio_in(DEVICE(&s->gsdma), i));
> +    }
> +    for (int i = 0; i < K230_DECOMP_GZIP_NUM_GPIOS_IN; i++) {
> +        qdev_connect_gpio_out(DEVICE(&s->gsdma), i,
> +                              qdev_get_gpio_in(DEVICE(&s->decomp_gzip), i));
> +    }
> +
>       /* unimplemented devices */
>       create_unimplemented_device("kpu.l2-cache",
>                                   memmap[K230_DEV_KPU_L2_CACHE].base,
> @@ -233,10 +252,6 @@ static void k230_soc_realize(DeviceState *dev, Error **errp)
>       create_unimplemented_device("dma", memmap[K230_DEV_DMA].base,
>                                   memmap[K230_DEV_DMA].size);
>   
> -    create_unimplemented_device("decomp-gzip",
> -                                memmap[K230_DEV_DECOMP_GZIP].base,
> -                                memmap[K230_DEV_DECOMP_GZIP].size);
> -
>       create_unimplemented_device("2d-engine.non-ai",
>                                   memmap[K230_DEV_NON_AI_2D].base,
>                                   memmap[K230_DEV_NON_AI_2D].size);
> diff --git a/include/hw/riscv/k230.h b/include/hw/riscv/k230.h
> index 156a386edc..a12d36965a 100644
> --- a/include/hw/riscv/k230.h
> +++ b/include/hw/riscv/k230.h
> @@ -19,6 +19,7 @@
>   #include "hw/riscv/riscv_hart.h"
>   #include "hw/watchdog/k230_wdt.h"
>   #include "hw/dma/k230_gsdma.h"
> +#include "hw/misc/k230_decomp_gzip.h"
>   
>   #define C908_CPU_HARTID   (0)
>   
> @@ -35,6 +36,7 @@ typedef struct K230SoCState {
>   
>       K230WdtState wdt[2];
>       K230GSDMAState gsdma;
> +    K230DecompGzipState decomp_gzip;
>       MemoryRegion sram;
>       MemoryRegion bootrom;
>